OSDN Git Service

usb: core: Use ACPI_SUCCESS() at appropriate places
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 18 Feb 2020 19:17:17 +0000 (21:17 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2020 10:08:52 +0000 (11:08 +0100)
Use ACPI_SUCCESS() to replace !ACPI_FAILURE(), this avoids additional operation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200218191717.73512-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/usb-acpi.c

index 99d41dc..50b2fc7 100644 (file)
@@ -187,7 +187,7 @@ usb_acpi_find_companion_for_port(struct usb_port *port_dev)
 
        handle = adev->handle;
        status = acpi_get_physical_device_location(handle, &pld);
-       if (!ACPI_FAILURE(status) && pld) {
+       if (ACPI_SUCCESS(status) && pld) {
                port_dev->location = USB_ACPI_LOCATION_VALID
                        | pld->group_token << 8 | pld->group_position;
                port_dev->connect_type = usb_acpi_get_connect_type(handle, pld);