OSDN Git Service

net: ethernet: adi: Fix invalid parent name length
authorAlexandru Tachici <alexandru.andrei.tachici@gmail.com>
Thu, 22 Sep 2022 06:30:49 +0000 (09:30 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Sep 2022 14:22:11 +0000 (07:22 -0700)
MII_BUS_ID_SIZE is larger than MAX_PHYS_ITEM_ID_LEN
so we use the former here to set the parent port id.

Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Link: https://lore.kernel.org/r/20220922063049.10388-1-alexandru.tachici@analog.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/adi/adin1110.c

index 4dacb98..4f3c372 100644 (file)
@@ -1028,7 +1028,7 @@ static int adin1110_port_get_port_parent_id(struct net_device *dev,
        struct adin1110_port_priv *port_priv = netdev_priv(dev);
        struct adin1110_priv *priv = port_priv->priv;
 
-       ppid->id_len = strnlen(priv->mii_bus_name, MII_BUS_ID_SIZE);
+       ppid->id_len = strnlen(priv->mii_bus_name, MAX_PHYS_ITEM_ID_LEN);
        memcpy(ppid->id, priv->mii_bus_name, ppid->id_len);
 
        return 0;