OSDN Git Service

irqchip/gic-v3-its: Fix u64 to __le64 warnings
authorBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
Thu, 17 Oct 2019 11:29:55 +0000 (12:29 +0100)
committerMarc Zyngier <maz@kernel.org>
Sun, 10 Nov 2019 18:47:45 +0000 (18:47 +0000)
The its_cmd_block struct can either have u64 or __le64
data in it, so make a anonymous union to remove the
sparse warnings when converting to/from these.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20191017112955.15853-1-ben.dooks@codethink.co.uk
drivers/irqchip/irq-gic-v3-its.c

index 787e8ee..021e0c7 100644 (file)
@@ -305,7 +305,10 @@ struct its_cmd_desc {
  * The ITS command block, which is what the ITS actually parses.
  */
 struct its_cmd_block {
-       u64     raw_cmd[4];
+       union {
+               u64     raw_cmd[4];
+               __le64  raw_cmd_le[4];
+       };
 };
 
 #define ITS_CMD_QUEUE_SZ               SZ_64K
@@ -414,10 +417,10 @@ static void its_encode_vpt_size(struct its_cmd_block *cmd, u8 vpt_size)
 static inline void its_fixup_cmd(struct its_cmd_block *cmd)
 {
        /* Let's fixup BE commands */
-       cmd->raw_cmd[0] = cpu_to_le64(cmd->raw_cmd[0]);
-       cmd->raw_cmd[1] = cpu_to_le64(cmd->raw_cmd[1]);
-       cmd->raw_cmd[2] = cpu_to_le64(cmd->raw_cmd[2]);
-       cmd->raw_cmd[3] = cpu_to_le64(cmd->raw_cmd[3]);
+       cmd->raw_cmd_le[0] = cpu_to_le64(cmd->raw_cmd[0]);
+       cmd->raw_cmd_le[1] = cpu_to_le64(cmd->raw_cmd[1]);
+       cmd->raw_cmd_le[2] = cpu_to_le64(cmd->raw_cmd[2]);
+       cmd->raw_cmd_le[3] = cpu_to_le64(cmd->raw_cmd[3]);
 }
 
 static struct its_collection *its_build_mapd_cmd(struct its_node *its,