OSDN Git Service

staging/atomisp: silence uninitialized variable warnings
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Mar 2017 07:51:50 +0000 (10:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Mar 2017 02:20:04 +0000 (11:20 +0900)
These print an uninitialized value for "opt".  Let's just remove the
printk.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c

index 327a5c5..7f7c6d5 100644 (file)
@@ -128,11 +128,9 @@ static ssize_t iunit_dbgfun_store(struct device_driver *drv, const char *buf,
        unsigned int opt;
        int ret;
 
-       if (kstrtouint(buf, 10, &opt)) {
-               dev_err(atomisp_dev, "%s setting %d value invalid\n",
-                       __func__, opt);
-               return -EINVAL;
-       }
+       ret = kstrtouint(buf, 10, &opt);
+       if (ret)
+               return ret;
 
        ret = atomisp_set_css_dbgfunc(iunit_debug.isp, opt);
        if (ret)
@@ -154,11 +152,9 @@ static ssize_t iunit_dbgopt_store(struct device_driver *drv, const char *buf,
        unsigned int opt;
        int ret;
 
-       if (kstrtouint(buf, 10, &opt)) {
-               dev_err(atomisp_dev, "%s setting %d value invalid\n",
-                       __func__, opt);
-               return -EINVAL;
-       }
+       ret = kstrtouint(buf, 10, &opt);
+       if (ret)
+               return ret;
 
        iunit_debug.dbgopt = opt;
        ret = iunit_dump_dbgopt(iunit_debug.isp, iunit_debug.dbgopt);