OSDN Git Service

mlxsw: spectrum_acl: Don't take mutex in mlxsw_sp_acl_tcam_vregion_rehash_work()
authorJiri Pirko <jiri@mellanox.com>
Sun, 24 Feb 2019 06:46:31 +0000 (06:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Feb 2019 04:25:29 +0000 (20:25 -0800)
Other mutexes are taking care of proper locking for this, no longer
needed to take RTNL mutex here.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c

index 5c8976e..822766f 100644 (file)
@@ -732,12 +732,7 @@ static void mlxsw_sp_acl_tcam_vregion_rehash_work(struct work_struct *work)
                container_of(work, struct mlxsw_sp_acl_tcam_vregion,
                             rehash_dw.work);
 
-       /* TODO: Take rtnl lock here as the rest of the code counts on it
-        * now. Later, this should be replaced by per-vregion lock.
-        */
-       rtnl_lock();
        mlxsw_sp_acl_tcam_vregion_rehash(vregion->mlxsw_sp, vregion);
-       rtnl_unlock();
        mlxsw_sp_acl_tcam_vregion_rehash_work_schedule(vregion);
 }