OSDN Git Service

ionic: clear linkcheck bit on alloc fail
authorShannon Nelson <snelson@pensando.io>
Thu, 1 Oct 2020 16:22:41 +0000 (09:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Oct 2020 23:30:01 +0000 (16:30 -0700)
Clear our link check requested flag on an allocation error.
We end up dropping this link check request, but that should
be fine as our watchdog will come back a few seconds later
and request it again.

Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 53ac0e4..5906145 100644 (file)
@@ -164,8 +164,10 @@ void ionic_link_status_check_request(struct ionic_lif *lif, bool can_sleep)
 
        if (!can_sleep) {
                work = kzalloc(sizeof(*work), GFP_ATOMIC);
-               if (!work)
+               if (!work) {
+                       clear_bit(IONIC_LIF_F_LINK_CHECK_REQUESTED, lif->state);
                        return;
+               }
 
                work->type = IONIC_DW_TYPE_LINK_STATUS;
                ionic_lif_deferred_enqueue(&lif->deferred, work);