Cppcheck: Class '...' has a constructor with 1 argument that is not explicit.

diff --git a/Externals/crystaledit/editlib/ccrystaleditview.cpp b/Externals/crystaledit/editlib/ccrystaleditview.cpp
index e366540..9f09c92 100644 (file)
--- a/Externals/crystaledit/editlib/ccrystaleditview.cpp
+++ b/Externals/crystaledit/editlib/ccrystaleditview.cpp
@@ -105,7 +105,7 @@ class CEditDropTargetImpl : public COleDropTarget
 private :
     CCrystalEditView * m_pOwner;
 public :
-    CEditDropTargetImpl (CCrystalEditView * pOwner)
+    explicit CEditDropTargetImpl (CCrystalEditView * pOwner)
       : m_pOwner(pOwner), m_pAlternateDropTarget(nullptr)
     {
     };

diff --git a/Externals/crystaledit/editlib/dialogs/ceditreplacedlg.h b/Externals/crystaledit/editlib/dialogs/ceditreplacedlg.h
index 9c51b4a..1686a26 100644 (file)
--- a/Externals/crystaledit/editlib/dialogs/ceditreplacedlg.h
+++ b/Externals/crystaledit/editlib/dialogs/ceditreplacedlg.h
@@ -50,7 +50,7 @@ private :
 
     // Construction
 public :
-    CEditReplaceDlg (CCrystalEditView * pBuddy);
+    explicit CEditReplaceDlg (CCrystalEditView * pBuddy);
     void SetLastSearch (LPCTSTR sText, bool bMatchCase, bool bWholeWord, bool bRegExp, int nScope, int nDirection);
     void UseLastSearch ();
     LastSearchInfos * GetLastSearchInfos (); 

diff --git a/Externals/crystaledit/editlib/dialogs/cfindtextdlg.h b/Externals/crystaledit/editlib/dialogs/cfindtextdlg.h
index bc89b9f..8db9307 100644 (file)
--- a/Externals/crystaledit/editlib/dialogs/cfindtextdlg.h
+++ b/Externals/crystaledit/editlib/dialogs/cfindtextdlg.h
@@ -65,7 +65,7 @@ private :
 
     // Construction
 public :
-    CFindTextDlg (CCrystalTextView * pBuddy);
+    explicit CFindTextDlg (CCrystalTextView * pBuddy);
     void SetLastSearch (LPCTSTR sText, bool bMatchCase, bool bWholeWord, bool bRegExp, int nDirection);
     void UseLastSearch ();
     LastSearchInfos * GetLastSearchInfos (); 

diff --git a/Externals/crystaledit/editlib/dialogs/ctextmarkerdlg.h b/Externals/crystaledit/editlib/dialogs/ctextmarkerdlg.h
index e1fd92f..3b8726b 100644 (file)
--- a/Externals/crystaledit/editlib/dialogs/ctextmarkerdlg.h
+++ b/Externals/crystaledit/editlib/dialogs/ctextmarkerdlg.h
@@ -16,29 +16,29 @@
 class EDITPADC_CLASS CTextMarkerDlg : public CDialog\r
   {\r
 private :\r
-       CCrystalTextMarkers m_tempMarkers;\r
-       CCrystalTextMarkers& m_markers;\r
-       int GetSelectedItemIndex() const;\r
-       void UpdateDataListView(bool bSaveAndValidate);\r
+    CCrystalTextMarkers m_tempMarkers;\r
+    CCrystalTextMarkers& m_markers;\r
+    int GetSelectedItemIndex() const;\r
+    void UpdateDataListView(bool bSaveAndValidate);\r
 \r
     // Construction\r
 public :\r
-    CTextMarkerDlg (CCrystalTextMarkers& markers, const CString& sPattern = _T(""), DWORD dwFlags = 0);\r
-       DWORD GetLastSearchFlags() const;\r
+    explicit CTextMarkerDlg (CCrystalTextMarkers& markers, const CString& sPattern = _T(""), DWORD dwFlags = 0);\r
+    DWORD GetLastSearchFlags() const;\r
 \r
     // Dialog Data\r
     //{{AFX_DATA(CTextMarkerDlg)\r
     enum { IDD = IDD_EDIT_MARKER };\r
     CComboBox m_ctlBgColorIdx;\r
     CButton m_ctlWholeWord;\r
-       CListCtrl m_listMarkers;\r
-       CString m_sFindWhat;\r
-       int m_nBgColorIndex;\r
-       int m_nCurItemIndex;\r
+    CListCtrl m_listMarkers;\r
+    CString m_sFindWhat;\r
+    int m_nBgColorIndex;\r
+    int m_nCurItemIndex;\r
     bool m_bMatchCase;\r
     bool m_bWholeWord;\r
     bool m_bRegExp;\r
-       bool m_bMarkersEnabled;\r
+    bool m_bMarkersEnabled;\r
     //}}AFX_DATA\r
 \r
     // Overrides\r
@@ -54,14 +54,14 @@ protected :
     // Generated message map functions\r
     //{{AFX_MSG(CTextMarkerDlg)\r
     virtual BOOL OnInitDialog ();\r
-       virtual void OnOK();\r
+    virtual void OnOK();\r
     afx_msg void OnBnclickedEditRegExp ();\r
-       afx_msg void OnBnClickedEditMarkerNew();\r
-       afx_msg void OnBnClickedEditMarkerDelete();\r
-       afx_msg void OnBnClickedApplyNow();\r
-       afx_msg void OnEditchangeEditFindtext();\r
-       afx_msg void OnItemchangingEditMarkerList(NMHDR *pNMHDR, LRESULT *pResult);\r
-       afx_msg void OnItemchangedEditMarkerList(NMHDR *pNMHDR, LRESULT *pResult);\r
+    afx_msg void OnBnClickedEditMarkerNew();\r
+    afx_msg void OnBnClickedEditMarkerDelete();\r
+    afx_msg void OnBnClickedApplyNow();\r
+    afx_msg void OnEditchangeEditFindtext();\r
+    afx_msg void OnItemchangingEditMarkerList(NMHDR *pNMHDR, LRESULT *pResult);\r
+    afx_msg void OnItemchangedEditMarkerList(NMHDR *pNMHDR, LRESULT *pResult);\r
     //}}AFX_MSG\r
     DECLARE_MESSAGE_MAP ()\r
 public:\r

diff --git a/Externals/crystaledit/editlib/dialogs/gotodlg.h b/Externals/crystaledit/editlib/dialogs/gotodlg.h
index 0dcd42c..f9d7131 100644 (file)
--- a/Externals/crystaledit/editlib/dialogs/gotodlg.h
+++ b/Externals/crystaledit/editlib/dialogs/gotodlg.h
@@ -31,7 +31,7 @@ private :
 
     // Construction
 public :
-    CGotoDlg (CCrystalTextView * pBuddy);
+    explicit CGotoDlg (CCrystalTextView * pBuddy);
 
     CPoint m_ptCurrentPos;
     // Dialog Data