OSDN Git Service

net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port
authorMurali Karicheri <m-karicheri2@ti.com>
Mon, 24 Aug 2020 15:10:53 +0000 (11:10 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Aug 2020 15:49:37 +0000 (08:49 -0700)
To flush the vid + mc entries from ALE, which is required when a VLAN
interface is removed, driver needs to call cpsw_ale_flush_multicast()
with ALE_PORT_HOST for port mask as these entries are added only for
host port. Without this, these entries remain in the ALE table even
after removing the VLAN interface. cpsw_ale_flush_multicast() calls
cpsw_ale_flush_mcast which expects a port mask to do the job.

Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw_new.c

index 1247d35..8d0a2bc 100644 (file)
@@ -1044,7 +1044,7 @@ static int cpsw_ndo_vlan_rx_kill_vid(struct net_device *ndev,
                           HOST_PORT_NUM, ALE_VLAN, vid);
        cpsw_ale_del_mcast(cpsw->ale, priv->ndev->broadcast,
                           0, ALE_VLAN, vid);
-       cpsw_ale_flush_multicast(cpsw->ale, 0, vid);
+       cpsw_ale_flush_multicast(cpsw->ale, ALE_PORT_HOST, vid);
 err:
        pm_runtime_put(cpsw->dev);
        return ret;