OSDN Git Service

ASoC: soc-component: add snd_soc_component_of_xlate_dai_id()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 26 Jul 2019 04:51:26 +0000 (13:51 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 5 Aug 2019 15:22:33 +0000 (16:22 +0100)
Current ALSA SoC is directly using component->driver->xxx,
thus, it is deep nested, and makes code difficult to read,
and is not good for encapsulation.
This patch adds new snd_soc_component_of_xlate_dai_id() and use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87zhl14d14.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc-component.h
sound/soc/soc-component.c
sound/soc/soc-core.c

index b8480d9..3f4acd3 100644 (file)
@@ -358,5 +358,7 @@ void snd_soc_component_resume(struct snd_soc_component *component);
 int snd_soc_component_is_suspended(struct snd_soc_component *component);
 int snd_soc_component_probe(struct snd_soc_component *component);
 void snd_soc_component_remove(struct snd_soc_component *component);
+int snd_soc_component_of_xlate_dai_id(struct snd_soc_component *component,
+                                     struct device_node *ep);
 
 #endif /* __SOC_COMPONENT_H */
index eba77ea..faf4999 100644 (file)
@@ -380,3 +380,12 @@ void snd_soc_component_remove(struct snd_soc_component *component)
        if (component->driver->remove)
                component->driver->remove(component);
 }
+
+int snd_soc_component_of_xlate_dai_id(struct snd_soc_component *component,
+                                     struct device_node *ep)
+{
+       if (component->driver->of_xlate_dai_id)
+               return component->driver->of_xlate_dai_id(component, ep);
+
+       return -ENOTSUPP;
+}
index 6a6403d..f63d09d 100644 (file)
@@ -3334,9 +3334,8 @@ int snd_soc_get_dai_id(struct device_node *ep)
        ret = -ENOTSUPP;
        mutex_lock(&client_mutex);
        component = soc_find_component(&dlc);
-       if (component &&
-           component->driver->of_xlate_dai_id)
-               ret = component->driver->of_xlate_dai_id(component, ep);
+       if (component)
+               ret = snd_soc_component_of_xlate_dai_id(component, ep);
        mutex_unlock(&client_mutex);
 
        of_node_put(dlc.of_node);