OSDN Git Service

irqchip/stm32: Fix initial values
authorLudovic Barre <ludovic.barre@st.com>
Mon, 6 Nov 2017 17:03:35 +0000 (18:03 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 7 Nov 2017 11:44:35 +0000 (11:44 +0000)
-After cold boot, imr default value depends on hardware configuration.
-After hot reboot the registers must be cleared to avoid residue.

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-stm32-exti.c

index 8f409a9..477d0fa 100644 (file)
@@ -258,7 +258,16 @@ __init stm32_exti_init(const struct stm32_exti_bank **stm32_exti_banks,
                writel_relaxed(~0UL, base + stm32_bank->rtsr_ofst);
                irqs_mask = readl_relaxed(base + stm32_bank->rtsr_ofst);
                nr_exti = fls(readl_relaxed(base + stm32_bank->rtsr_ofst));
+
+               /*
+                * This IP has no reset, so after hot reboot we should
+                * clear registers to avoid residue
+                */
+               writel_relaxed(0, base + stm32_bank->imr_ofst);
+               writel_relaxed(0, base + stm32_bank->emr_ofst);
                writel_relaxed(0, base + stm32_bank->rtsr_ofst);
+               writel_relaxed(0, base + stm32_bank->ftsr_ofst);
+               writel_relaxed(~0UL, base + stm32_bank->pr_ofst);
 
                pr_info("%s: bank%d, External IRQs available:%#x\n",
                        node->full_name, i, irqs_mask);