Only create debugTag if necessary

 Bug: 7238418
 String concatenation isn't free

Change-Id: I510a89ef8b673efb631d6f8929ab3d9d9b454931

diff --git a/src/com/android/gallery3d/data/ImageCacheRequest.java b/src/com/android/gallery3d/data/ImageCacheRequest.java
index b977b10..3f937e3 100644 (file)
--- a/src/com/android/gallery3d/data/ImageCacheRequest.java
+++ b/src/com/android/gallery3d/data/ImageCacheRequest.java
@@ -41,11 +41,14 @@ abstract class ImageCacheRequest implements Job<Bitmap> {
         mTargetSize = targetSize;
     }
 
+    private String debugTag() {
+        return mPath + "," +
+                ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" :
+                (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?");
+    }
+
     @Override
     public Bitmap run(JobContext jc) {
-        String debugTag = mPath + "," +
-                 ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" :
-                 (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?");
         ImageCacheService cacheService = mApplication.getImageCacheService();
 
         BytesBuffer buffer = MediaItem.getBytesBufferPool().get();
@@ -66,7 +69,7 @@ abstract class ImageCacheRequest implements Job<Bitmap> {
                             MediaItem.getThumbPool());
                 }
                 if (bitmap == null && !jc.isCancelled()) {
-                    Log.w(TAG, "decode cached failed " + debugTag);
+                    Log.w(TAG, "decode cached failed " + debugTag());
                 }
                 return bitmap;
             }
@@ -77,7 +80,7 @@ abstract class ImageCacheRequest implements Job<Bitmap> {
         if (jc.isCancelled()) return null;
 
         if (bitmap == null) {
-            Log.w(TAG, "decode orig failed " + debugTag);
+            Log.w(TAG, "decode orig failed " + debugTag());
             return null;
         }