> In both datetime_trunc() and timespan_trunc() in dt.c,

> the DTK_MICROSEC case is just like the DTK_MILLISEC case.
> I think this is wrong and it ought to look like
>         fsec = rint(fsec * 1000000) / 1000000;
> no?

Tom Lane.

diff --git a/doc/TODO b/doc/TODO
index 99bccdf..244941d 100644 (file)
--- a/doc/TODO
+++ b/doc/TODO
@@ -93,7 +93,7 @@ TYPES
 * Allow LOCALE on a per-column basis, default to ASCII
 * Allow array on int8[]
 * Remove Money type, add money formatting for decimal type
-* Fix typein/out functions to not be user-callable
+* Declare typein/out functions in pg_proc with a special "C string" data type
 * Add non-large-object binary field
 * Add index on NUMERIC type
 
@@ -190,6 +190,7 @@ INDEXES
 * Improve LIMIT processing by using index to limit rows processed
 * Have optimizer take LIMIT into account when considering index scans
 * Make index creation use psort code, because it is now faster(Vadim)
+* Allow creation of sort temp tables > 1 Gig
 * Create more system table indexes for faster cache lookups
 * fix indexscan() so it does leak memory by not requiring caller to free
 * Improve _bt_binsrch() to handle equal keys better, remove _bt_firsteq()(Tom)

diff --git a/src/backend/utils/adt/dt.c b/src/backend/utils/adt/dt.c
index 9fb75cb..74028c4 100644 (file)
--- a/src/backend/utils/adt/dt.c
+++ b/src/backend/utils/adt/dt.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/backend/utils/adt/Attic/dt.c,v 1.71 1999/05/25 16:12:00 momjian Exp $
+ *       $Header: /cvsroot/pgsql/src/backend/utils/adt/Attic/dt.c,v 1.72 1999/07/08 03:22:46 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1429,7 +1429,7 @@ datetime_trunc(text *units, DateTime *datetime)
                                        break;
 
                                case DTK_MICROSEC:
-                                       fsec = rint(fsec * 1000) / 1000;
+                                       fsec = rint(fsec * 1000000) / 1000000;
                                        break;
 
                                default:
@@ -1573,7 +1573,7 @@ timespan_trunc(text *units, TimeSpan *timespan)
                                        break;
 
                                case DTK_MICROSEC:
-                                       fsec = rint(fsec * 1000) / 1000;
+                                       fsec = rint(fsec * 1000000) / 1000000;
                                        break;
 
                                default: