OSDN Git Service

drm/i915/bios: don't initialize fields based on vbt version
authorJani Nikula <jani.nikula@intel.com>
Thu, 28 Sep 2017 08:21:59 +0000 (11:21 +0300)
committerJani Nikula <jani.nikula@intel.com>
Tue, 10 Oct 2017 06:05:44 +0000 (09:05 +0300)
In theory, these might clobber information for older VBT versions.

We might have to store the BDB version for later parsing, but currently
all code accessing these fields will only use them on newer platforms
with new enough BDB versions.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/0232d9cb258e8f83c4180cdb8aad1459a312ec2a.1506586821.git.jani.nikula@intel.com
drivers/gpu/drm/i915/intel_bios.c

index 2292461..c91cdf1 100644 (file)
@@ -1347,19 +1347,6 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
                 */
                memcpy(child_dev_ptr, child,
                       min_t(size_t, defs->child_dev_size, sizeof(*child)));
-
-               /*
-                * copied full block, now init values when they are not
-                * available in current version
-                */
-               if (bdb->version < 196) {
-                       /* Set default values for bits added from v196 */
-                       child_dev_ptr->iboost = 0;
-                       child_dev_ptr->hpd_invert = 0;
-               }
-
-               if (bdb->version < 192)
-                       child_dev_ptr->lspcon = 0;
        }
        return;
 }