OSDN Git Service

Input: wacom_w8001 - allocate additional space for 'phys'
authorJason Gerecke <killertofu@gmail.com>
Fri, 16 Aug 2019 22:07:15 +0000 (15:07 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 20 Aug 2019 19:03:46 +0000 (12:03 -0700)
GCC warns that the output of our call to 'snprintf' in 'w8001_connect'
may be truncated since both 'serio->phys' and 'w8001->phys' are 32 bytes
in length. Increase the amount of space allocated for the latter to
compensate.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/wacom_w8001.c

index 3715d1e..691285a 100644 (file)
@@ -27,6 +27,8 @@ MODULE_AUTHOR("Jaya Kumar <jayakumar.lkml@gmail.com>");
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
 
+#define W8001_MAX_PHYS         42
+
 #define W8001_MAX_LENGTH       13
 #define W8001_LEAD_MASK                0x80
 #define W8001_LEAD_BYTE                0x80
@@ -89,7 +91,7 @@ struct w8001 {
        unsigned char response_type;
        unsigned char response[W8001_MAX_LENGTH];
        unsigned char data[W8001_MAX_LENGTH];
-       char phys[32];
+       char phys[W8001_MAX_PHYS];
        int type;
        unsigned int pktlen;
        u16 max_touch_x;