OSDN Git Service

usb: mtp: fix error path memory leak
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 25 Apr 2014 10:01:55 +0000 (12:01 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 5 May 2014 10:57:45 +0000 (12:57 +0200)
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/usb/dev-mtp.c

index 775dc8d..45f9562 100644 (file)
@@ -669,6 +669,7 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTPControl *c,
 
     d->fd = open(o->path, O_RDONLY);
     if (d->fd == -1) {
+        usb_mtp_data_free(d);
         return NULL;
     }
     d->length = o->stat.st_size;
@@ -688,6 +689,7 @@ static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c,
 
     d->fd = open(o->path, O_RDONLY);
     if (d->fd == -1) {
+        usb_mtp_data_free(d);
         return NULL;
     }