OSDN Git Service

drm: tidss: Fix pixel format definition
authorRandolph Sapp <rs@ti.com>
Fri, 2 Dec 2022 00:18:03 +0000 (18:18 -0600)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 16 Dec 2022 17:24:39 +0000 (19:24 +0200)
There was a long-standing bug from a typo that created 2 ARGB1555 and
ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
me to this issue.

According to the Supported Pixel Data formats table we have the later
entries should have been for Alpha-X instead.

Signed-off-by: Randolph Sapp <rs@ti.com>
Fixes: 32a1795f57eecc ("drm/tidss: New driver for TI Keystone platform Display SubSystem")
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Acked-by: Andrew Davis <afd@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221202001803.1765805-1-rs@ti.com
drivers/gpu/drm/tidss/tidss_dispc.c

index 7a08feb..165365b 100644 (file)
@@ -1858,8 +1858,8 @@ static const struct {
        { DRM_FORMAT_XBGR4444, 0x21, },
        { DRM_FORMAT_RGBX4444, 0x22, },
 
-       { DRM_FORMAT_ARGB1555, 0x25, },
-       { DRM_FORMAT_ABGR1555, 0x26, },
+       { DRM_FORMAT_XRGB1555, 0x25, },
+       { DRM_FORMAT_XBGR1555, 0x26, },
 
        { DRM_FORMAT_XRGB8888, 0x27, },
        { DRM_FORMAT_XBGR8888, 0x28, },