OSDN Git Service

Fix a use-of-uninitialized-value warning.
authorGeorge Burgess IV <gbiv@google.com>
Tue, 24 Jan 2017 23:48:28 +0000 (15:48 -0800)
committerGeorge Burgess IV <gbiv@google.com>
Tue, 24 Jan 2017 23:48:28 +0000 (15:48 -0800)
Caught by clang's static analyzer:
frameworks/base/core/jni/android_hardware_SoundTrigger.cpp:660:20:
warning: Assigned value is garbage or undefined
        nHandle[0] = (jint)handle;

Given that we return an error code anyway, we can just set it to 0 and
move on.

Bug: None
Test: Still builds; static analyzer doesn't complain.
Change-Id: I9a5be562a0d96fd6c48bb98eca0867fc754bba63

core/jni/android_hardware_SoundTrigger.cpp

index 793d132..0c7f5a1 100644 (file)
@@ -509,7 +509,7 @@ android_hardware_SoundTrigger_loadSoundModel(JNIEnv *env, jobject thiz,
     sp<MemoryDealer> memoryDealer;
     sp<IMemory> memory;
     size_t size;
-    sound_model_handle_t handle;
+    sound_model_handle_t handle = 0;
     jobject jUuid;
     jstring jUuidString;
     const char *nUuidString;