OSDN Git Service

drm/via: use ARRAY_SIZE
authorJérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Mon, 16 Oct 2017 02:33:56 +0000 (22:33 -0400)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 16 Oct 2017 09:29:28 +0000 (11:29 +0200)
Using the ARRAY_SIZE macro improves the readability of the code.

Found with Coccinelle with the following semantic patch:
@r depends on (org || report)@
type T;
T[] E;
position p;
@@
(
 (sizeof(E)@p /sizeof(*E))
|
 (sizeof(E)@p /sizeof(E[...]))
|
 (sizeof(E)@p /sizeof(T))
)

Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20171016023357.20174-1-jeremy.lefaure@lse.epita.fr
drivers/gpu/drm/via/via_verifier.c

index 0677bbf..fb26094 100644 (file)
@@ -34,6 +34,7 @@
 #include <drm/drm_legacy.h>
 #include "via_verifier.h"
 #include "via_drv.h"
+#include <linux/kernel.h>
 
 typedef enum {
        state_command,
@@ -1102,10 +1103,7 @@ setup_hazard_table(hz_init_t init_table[], hazard_t table[], int size)
 
 void via_init_command_verifier(void)
 {
-       setup_hazard_table(init_table1, table1,
-                          sizeof(init_table1) / sizeof(hz_init_t));
-       setup_hazard_table(init_table2, table2,
-                          sizeof(init_table2) / sizeof(hz_init_t));
-       setup_hazard_table(init_table3, table3,
-                          sizeof(init_table3) / sizeof(hz_init_t));
+       setup_hazard_table(init_table1, table1, ARRAY_SIZE(init_table1));
+       setup_hazard_table(init_table2, table2, ARRAY_SIZE(init_table2));
+       setup_hazard_table(init_table3, table3, ARRAY_SIZE(init_table3));
 }