OSDN Git Service

USB: fix coccinelle warnings
authorFengguang Wu <fengguang.wu@intel.com>
Thu, 5 Dec 2013 04:36:31 +0000 (20:36 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2013 04:36:31 +0000 (20:36 -0800)
drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0, suggest !E
/c/kernel-tests/src/cocci/drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0

 Compare pointer-typed values to NULL rather than 0

Semantic patch information:
 This makes an effort to choose between !x and x == NULL.  !x is used
 if it has previously been used with the function used to initialize x.
 This relies on type information.  More type information can be obtained
 using the option -all_includes and the option -I to specify an
 include path.

Generated by: coccinelle/null/badzero.cocci

CC: Jingoo Han <jg1.han@samsung.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
drivers/usb/host/ehci-mv.c

index 417c10d..6e8afca 100644 (file)
@@ -178,7 +178,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
 
        ehci_mv->phy_regs = devm_ioremap(&pdev->dev, r->start,
                                         resource_size(r));
-       if (ehci_mv->phy_regs == 0) {
+       if (!ehci_mv->phy_regs) {
                dev_err(&pdev->dev, "failed to map phy I/O memory\n");
                retval = -EFAULT;
                goto err_put_hcd;