OSDN Git Service

USB: gadget: udc: fix wrong pointer passed to IS_ERR() and PTR_ERR()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 30 Mar 2021 13:01:59 +0000 (21:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Apr 2021 13:40:38 +0000 (15:40 +0200)
IS_ERR() and PTR_ERR() use wrong pointer, it should be
udc->virt_addr, fix it.

Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210330130159.1051979-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/snps_udc_plat.c

index 32f1d3e..99805d6 100644 (file)
@@ -114,8 +114,8 @@ static int udc_plat_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        udc->virt_addr = devm_ioremap_resource(dev, res);
-       if (IS_ERR(udc->regs))
-               return PTR_ERR(udc->regs);
+       if (IS_ERR(udc->virt_addr))
+               return PTR_ERR(udc->virt_addr);
 
        /* udc csr registers base */
        udc->csr = udc->virt_addr + UDC_CSR_ADDR;