OSDN Git Service

IB/mlx5: Verify that driver supports user flags
authorYonatan Cohen <yonatanc@mellanox.com>
Tue, 9 Oct 2018 09:05:14 +0000 (12:05 +0300)
committerDoug Ledford <dledford@redhat.com>
Wed, 17 Oct 2018 15:25:41 +0000 (11:25 -0400)
Flags sent down from user might not be supported by
running driver.
This might lead to unwanted bugs.
To solve this, added macro to test for unsupported flags.

Signed-off-by: Yonatan Cohen <yonatanc@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx5/qp.c

index 817c391..5b1811b 100644 (file)
@@ -1728,6 +1728,11 @@ static void configure_requester_scat_cqe(struct mlx5_ib_dev *dev,
                MLX5_SET(qpc, qpc, cs_req, MLX5_REQ_SCAT_DATA32_CQE);
 }
 
+static inline bool check_flags_mask(uint64_t input, uint64_t supported)
+{
+       return (input & ~supported) == 0;
+}
+
 static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
                            struct ib_qp_init_attr *init_attr,
                            struct ib_udata *udata, struct mlx5_ib_qp *qp)
@@ -1825,6 +1830,15 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
                        return -EFAULT;
                }
 
+               if (!check_flags_mask(ucmd.flags,
+                                     MLX5_QP_FLAG_SIGNATURE |
+                                             MLX5_QP_FLAG_SCATTER_CQE |
+                                             MLX5_QP_FLAG_TUNNEL_OFFLOADS |
+                                             MLX5_QP_FLAG_BFREG_INDEX |
+                                             MLX5_QP_FLAG_TYPE_DCT |
+                                             MLX5_QP_FLAG_TYPE_DCI))
+                       return -EINVAL;
+
                err = get_qp_user_index(to_mucontext(pd->uobject->context),
                                        &ucmd, udata->inlen, &uidx);
                if (err)