OSDN Git Service

mips: bpf: Fix broken BPF_MOD
authorDenis Kirjanov <kda@linux-powerpc.org>
Mon, 1 Dec 2014 09:57:02 +0000 (12:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Dec 2014 01:22:30 +0000 (20:22 -0500)
Remove optimize_div() from BPF_MOD | BPF_K case
since we don't know the dividend and fix the
emit_mod() by reading the mod operation result from HI register

Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/mips/net/bpf_jit.c

index 9b55143..9fd6834 100644 (file)
@@ -426,7 +426,7 @@ static inline void emit_mod(unsigned int dst, unsigned int src,
                u32 *p = &ctx->target[ctx->idx];
                uasm_i_divu(&p, dst, src);
                p = &ctx->target[ctx->idx + 1];
-               uasm_i_mflo(&p, dst);
+               uasm_i_mfhi(&p, dst);
        }
        ctx->idx += 2; /* 2 insts */
 }
@@ -971,7 +971,7 @@ load_ind:
                        break;
                case BPF_ALU | BPF_MOD | BPF_K:
                        /* A %= k */
-                       if (k == 1 || optimize_div(&k)) {
+                       if (k == 1) {
                                ctx->flags |= SEEN_A;
                                emit_jit_reg_move(r_A, r_zero, ctx);
                        } else {