OSDN Git Service

ASoC: tlv320aic26: use DEVICE_ATTR_RW macro
authorYueHaibing <yuehaibing@huawei.com>
Mon, 24 May 2021 11:51:31 +0000 (19:51 +0800)
committerMark Brown <broonie@sirena.org.uk>
Tue, 25 May 2021 15:45:06 +0000 (16:45 +0100)
Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Message-Id: <20210524115131.46288-1-yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@sirena.org.uk>
sound/soc/codecs/tlv320aic26.c

index c7baef8..077415a 100644 (file)
@@ -261,8 +261,8 @@ static const struct snd_kcontrol_new aic26_snd_controls[] = {
  * SPI device portion of driver: sysfs files for debugging
  */
 
-static ssize_t aic26_keyclick_show(struct device *dev,
-                                  struct device_attribute *attr, char *buf)
+static ssize_t keyclick_show(struct device *dev,
+                            struct device_attribute *attr, char *buf)
 {
        struct aic26 *aic26 = dev_get_drvdata(dev);
        int val, amp, freq, len;
@@ -276,9 +276,9 @@ static ssize_t aic26_keyclick_show(struct device *dev,
 }
 
 /* Any write to the keyclick attribute will trigger the keyclick event */
-static ssize_t aic26_keyclick_set(struct device *dev,
-                                 struct device_attribute *attr,
-                                 const char *buf, size_t count)
+static ssize_t keyclick_store(struct device *dev,
+                             struct device_attribute *attr,
+                             const char *buf, size_t count)
 {
        struct aic26 *aic26 = dev_get_drvdata(dev);
 
@@ -288,7 +288,7 @@ static ssize_t aic26_keyclick_set(struct device *dev,
        return count;
 }
 
-static DEVICE_ATTR(keyclick, 0644, aic26_keyclick_show, aic26_keyclick_set);
+static DEVICE_ATTR_RW(keyclick);
 
 /* ---------------------------------------------------------------------
  * SoC CODEC portion of driver: probe and release routines