OSDN Git Service

drm/i915/selftest: Disable IRQ for timestamp calculation
authorAnshuman Gupta <anshuman.gupta@intel.com>
Tue, 30 Nov 2021 13:20:05 +0000 (18:50 +0530)
committerAnshuman Gupta <anshuman.gupta@intel.com>
Fri, 3 Dec 2021 08:14:13 +0000 (13:44 +0530)
gt_pm selftest calculates engine ticks cycles and wall time
cycles by delta of respective engine elapsed TIMESTAMP and ktime
for period of 1000us.
It compares the engine ticks cycles with wall time cycles.

Disable local cpu interrupt so that interrupt handler does not
switch out the thread during measure_clocks() and prevent
miscalculation of engine tick cycles.

v2:
- nuke preempt_{disable,enable}, as disable_local_irq()
  disable the preemption. (Chris)

Cc: Chris P Wilson <chris.p.wilson@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211130132005.6305-1-anshuman.gupta@intel.com
drivers/gpu/drm/i915/gt/selftest_gt_pm.c

index b944121..55c5cdb 100644 (file)
@@ -43,7 +43,7 @@ static void measure_clocks(struct intel_engine_cs *engine,
        int i;
 
        for (i = 0; i < 5; i++) {
-               preempt_disable();
+               local_irq_disable();
                cycles[i] = -ENGINE_READ_FW(engine, RING_TIMESTAMP);
                dt[i] = ktime_get();
 
@@ -51,7 +51,7 @@ static void measure_clocks(struct intel_engine_cs *engine,
 
                dt[i] = ktime_sub(ktime_get(), dt[i]);
                cycles[i] += ENGINE_READ_FW(engine, RING_TIMESTAMP);
-               preempt_enable();
+               local_irq_enable();
        }
 
        /* Use the median of both cycle/dt; close enough */