kdirshare: minor review

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

diff --git a/kdirshare/kded/kded_kdirshare.cpp b/kdirshare/kded/kded_kdirshare.cpp
index 1fe3436..94b5256 100644 (file)
--- a/kdirshare/kded/kded_kdirshare.cpp
+++ b/kdirshare/kded/kded_kdirshare.cpp
@@ -20,8 +20,8 @@
 
 #include <klocale.h>
 #include <ksettings.h>
-#include <kdebug.h>
 #include <kpluginfactory.h>
+#include <kdebug.h>
 
 static quint16 getRandomPort()
 {
@@ -71,7 +71,7 @@ QString KDirShareModule::share(const QString &dirpath)
         kdirshareimpl->deleteLater();
         return i18n("Could not serve: %1", kdirshareimpl->errorString());
     }
-    if (!kdirshareimpl->publishService()) {
+    if (!kdirshareimpl->publish()) {
         kdirshareimpl->stop();
         kdirshareimpl->deleteLater();
         return i18n("Could not publish service for: %1", dirpath);

diff --git a/kdirshare/kded/kded_kdirshare.h b/kdirshare/kded/kded_kdirshare.h
index f46b845..896ce9f 100644 (file)
--- a/kdirshare/kded/kded_kdirshare.h
+++ b/kdirshare/kded/kded_kdirshare.h
@@ -19,9 +19,10 @@
 #ifndef KDIRSHARE_KDED_H
 #define KDIRSHARE_KDED_H
 
+#include "kdirshareimpl.h"
+
 #include <QList>
 #include <kdedmodule.h>
-#include "kdirshareimpl.h"
 
 class KDirShareModule: public KDEDModule
 {

diff --git a/kdirshare/kded/kdirshareimpl.cpp b/kdirshare/kded/kdirshareimpl.cpp
index 4ab1a6d..c4c43b7 100644 (file)
--- a/kdirshare/kded/kdirshareimpl.cpp
+++ b/kdirshare/kded/kdirshareimpl.cpp
@@ -128,7 +128,7 @@ bool KDirShareImpl::serve(const QHostAddress &address, const quint16 port)
     return start(address, port);
 }
 
-bool KDirShareImpl::publishService()
+bool KDirShareImpl::publish()
 {
     return m_kdnssd.publishService(
         "_http._tcp", m_port,
@@ -179,3 +179,5 @@ void KDirShareImpl::respond(const QByteArray &url, QByteArray *outdata, ushort *
         outheaders->insert("Content-Type", "text/html; charset=UTF-8");
     }
 }
+
+#include "moc_kdirshareimpl.cpp"

diff --git a/kdirshare/kded/kdirshareimpl.h b/kdirshare/kded/kdirshareimpl.h
index 19f15f3..562261a 100644 (file)
--- a/kdirshare/kded/kdirshareimpl.h
+++ b/kdirshare/kded/kdirshareimpl.h
@@ -32,7 +32,7 @@ public:
     QString directory() const;
     bool setDirectory(const QString &dirpath);
     bool serve(const QHostAddress &address, const quint16 port);
-    bool publishService();
+    bool publish();
 
 protected:
     void respond(const QByteArray &url, QByteArray *outdata, ushort *outhttpstatus, KHTTPHeaders *outheaders) final;