OSDN Git Service

gpu: drm: radeon: si: Replace mdelay() with msleep() in si_pcie_gen3_enable()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Sat, 4 Aug 2018 00:33:44 +0000 (08:33 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 27 Aug 2018 16:10:02 +0000 (11:10 -0500)
si_pcie_gen3_enable() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/si.c

index 85c604d..841bc8b 100644 (file)
@@ -7183,7 +7183,7 @@ static void si_pcie_gen3_enable(struct radeon_device *rdev)
                                tmp |= LC_REDO_EQ;
                                WREG32_PCIE_PORT(PCIE_LC_CNTL4, tmp);
 
-                               mdelay(100);
+                               msleep(100);
 
                                /* linkctl */
                                pci_read_config_word(root, bridge_pos + PCI_EXP_LNKCTL, &tmp16);