OSDN Git Service

media: imx: imx7-media-csi: Move variable to loop scope
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 6 Sep 2022 23:04:01 +0000 (00:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 08:32:09 +0000 (08:32 +0000)
The phys variable is only used as a local loop variable in
imx7_csi_setup_vb2_buf(), with each entry in the array being used in the
corresponding iteration of the loop only. Move it to loop scope,
simplifying the array to a single variable.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/imx/imx7-media-csi.c

index e643a9f..b67e846 100644 (file)
@@ -398,21 +398,22 @@ static void imx7_csi_setup_vb2_buf(struct imx7_csi *csi)
 {
        struct imx7_csi_vb2_buffer *buf;
        struct vb2_buffer *vb2_buf;
-       dma_addr_t phys[2];
        int i;
 
        for (i = 0; i < 2; i++) {
+               dma_addr_t phys;
+
                buf = imx7_csi_video_next_buf(csi);
                if (buf) {
                        csi->active_vb2_buf[i] = buf;
                        vb2_buf = &buf->vbuf.vb2_buf;
-                       phys[i] = vb2_dma_contig_plane_dma_addr(vb2_buf, 0);
+                       phys = vb2_dma_contig_plane_dma_addr(vb2_buf, 0);
                } else {
                        csi->active_vb2_buf[i] = NULL;
-                       phys[i] = csi->underrun_buf.phys;
+                       phys = csi->underrun_buf.phys;
                }
 
-               imx7_csi_update_buf(csi, phys[i], i);
+               imx7_csi_update_buf(csi, phys, i);
        }
 }