OSDN Git Service

scsi: megaraid_sas: Remove redundant memset() statement
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 5 May 2022 14:32:13 +0000 (07:32 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 May 2022 00:16:26 +0000 (20:16 -0400)
As memset() of scmd->sense_buffer is immediately followed by a memcpy()
where scmd->sense_buffer is the destination. The memset() is redundant.

Link: https://lore.kernel.org/r/20220505143214.44908-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_fusion.c

index 54fde26..5b5885d 100644 (file)
@@ -2047,8 +2047,6 @@ map_cmd_status(struct fusion_context *fusion,
 
                scmd->result = (DID_OK << 16) | ext_status;
                if (ext_status == SAM_STAT_CHECK_CONDITION) {
-                       memset(scmd->sense_buffer, 0,
-                              SCSI_SENSE_BUFFERSIZE);
                        memcpy(scmd->sense_buffer, sense,
                               SCSI_SENSE_BUFFERSIZE);
                }