OSDN Git Service

net/mlx5: Reduce flow counters bulk query buffer size for SFs
authorAvihai Horon <avihaih@nvidia.com>
Wed, 6 Oct 2021 09:19:40 +0000 (12:19 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Mon, 25 Oct 2021 20:51:18 +0000 (13:51 -0700)
Currently, the flow counters bulk query buffer takes a little more than
512KB of memory, which is aligned to the next power of 2, to 1MB.

The buffer size determines the maximum number of flow counters that can
be queried at a time. Thus, having a bigger buffer can improve
performance for users that need to query many flow counters.

SFs don't use many flow counters and don't need a big buffer. Since this
size is critical with large scale, reduce the size of the bulk query
buffer for SFs.

Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c

index f542a36..60c9df1 100644 (file)
@@ -40,6 +40,7 @@
 #define MLX5_FC_STATS_PERIOD msecs_to_jiffies(1000)
 /* Max number of counters to query in bulk read is 32K */
 #define MLX5_SW_MAX_COUNTERS_BULK BIT(15)
+#define MLX5_SF_NUM_COUNTERS_BULK 6
 #define MLX5_FC_POOL_MAX_THRESHOLD BIT(18)
 #define MLX5_FC_POOL_USED_BUFF_RATIO 10
 
@@ -146,8 +147,12 @@ static void mlx5_fc_stats_remove(struct mlx5_core_dev *dev,
 
 static int get_max_bulk_query_len(struct mlx5_core_dev *dev)
 {
-       return min_t(int, MLX5_SW_MAX_COUNTERS_BULK,
-                         (1 << MLX5_CAP_GEN(dev, log_max_flow_counter_bulk)));
+       int num_counters_bulk = mlx5_core_is_sf(dev) ?
+                                       MLX5_SF_NUM_COUNTERS_BULK :
+                                       MLX5_SW_MAX_COUNTERS_BULK;
+
+       return min_t(int, num_counters_bulk,
+                    (1 << MLX5_CAP_GEN(dev, log_max_flow_counter_bulk)));
 }
 
 static void update_counter_cache(int index, u32 *bulk_raw_data,