OSDN Git Service

[PATCH] WATCHDOG: sc1200wdt.c pnp unregister fix.
authorAkinobu Mita <akinobu.mita@gmail.com>
Sat, 4 Nov 2006 20:59:39 +0000 (21:59 +0100)
committerWilly Tarreau <w@1wt.eu>
Sat, 4 Nov 2006 21:38:26 +0000 (22:38 +0100)
(backport from 2.6-stable)

If no devices found or invalid parameter is specified,
scl200wdt_pnp_driver is left unregistered.
It breaks global list of pnp drivers.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
For 2.4 backport :
Acked-by: Wim Van Sebroeck <wim@iguana.be>
drivers/char/sc1200wdt.c

index 73827c7..7c9940c 100644 (file)
@@ -382,7 +382,7 @@ static int __init sc1200wdt_init(void)
        if (io == -1) {
                printk(KERN_ERR PFX "io parameter must be specified\n");
                ret = -EINVAL;
-               goto out_clean;
+               goto out_pnp;
        }
 
        if (!request_region(io, io_len, SC1200_MODULE_NAME)) {