OSDN Git Service

staging: iio: cdc/ad7746: fix missing return value
authorArnd Bergmann <arnd@arndb.de>
Tue, 25 Oct 2016 15:56:23 +0000 (17:56 +0200)
committerJonathan Cameron <jic23@kernel.org>
Tue, 25 Oct 2016 16:25:34 +0000 (17:25 +0100)
As found by "gcc -Wmaybe-uninitialized", the latest change to the
driver lacked an initalization for the return code in one of the
added cases:

drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’:
drivers/staging/iio/cdc/ad7746.c:655:2: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

This sets it to IIO_VAL_INT, which I think is what we want here.

Fixes: 2296c0623eb7 ("staging: iio: cdc: ad7746: implement IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/cdc/ad7746.c

index f41251c..a5828f9 100644 (file)
@@ -642,6 +642,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
                case IIO_VOLTAGE:
                        *val = ad7746_vt_filter_rate_table[
                                        (chip->config >> 6) & 0x3][0];
+                       ret = IIO_VAL_INT;
                        break;
                default:
                        ret = -EINVAL;