OSDN Git Service

Make some accessibility related slices public.
authorYi-Ling Chuang <emilychuang@google.com>
Wed, 27 Nov 2019 09:48:21 +0000 (17:48 +0800)
committerYi-Ling Chuang <emilychuang@google.com>
Thu, 28 Nov 2019 06:31:48 +0000 (14:31 +0800)
Only PreferenceControllers with isPublicSlice() set to true are exposed
to other apps. Others will be Settings only.

Bug: 141088937
Test: robotests
Change-Id: If0fa79f7c270b10f8f1a47cb5f914d19566dedfb

src/com/android/settings/accessibility/AccessibilitySlicePreferenceController.java
src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java
src/com/android/settings/accessibility/MagnificationNavbarPreferenceController.java
tests/robotests/src/com/android/settings/accessibility/AccessibilitySlicePreferenceControllerTest.java
tests/robotests/src/com/android/settings/accessibility/MagnificationGesturesPreferenceControllerTest.java
tests/robotests/src/com/android/settings/accessibility/MagnificationNavbarPreferenceControllerTest.java

index d1a60fa..e53afeb 100644 (file)
@@ -91,7 +91,7 @@ public class AccessibilitySlicePreferenceController extends TogglePreferenceCont
     }
 
     @Override
-    public boolean isSliceable() {
+    public boolean isPublicSlice() {
         return true;
     }
 
index f613c69..31a8c19 100644 (file)
@@ -70,6 +70,11 @@ public class MagnificationGesturesPreferenceController extends TogglePreferenceC
     }
 
     @Override
+    public boolean isPublicSlice() {
+        return true;
+    }
+
+    @Override
     public CharSequence getSummary() {
         int resId = 0;
         if (mIsFromSUW) {
index 5af5d93..1b8d854 100644 (file)
@@ -77,6 +77,11 @@ public class MagnificationNavbarPreferenceController extends TogglePreferenceCon
     }
 
     @Override
+    public boolean isPublicSlice() {
+        return true;
+    }
+
+    @Override
     public CharSequence getSummary() {
         int resId = 0;
         if (mIsFromSUW) {
index 471f107..16ff3c4 100644 (file)
@@ -121,6 +121,16 @@ public class AccessibilitySlicePreferenceControllerTest {
         new AccessibilitySlicePreferenceController(mContext, "not_split_by_slash");
     }
 
+    @Test
+    public void isSliceable_returnTrue() {
+        assertThat(mController.isSliceable()).isTrue();
+    }
+
+    @Test
+    public void isPublicSlice_returnTrue() {
+        assertThat(mController.isPublicSlice()).isTrue();
+    }
+
     private List<AccessibilityServiceInfo> getFakeServiceList() {
         final List<AccessibilityServiceInfo> infoList = new ArrayList<>();
 
index c6bf343..c7d70e0 100644 (file)
@@ -130,4 +130,9 @@ public class MagnificationGesturesPreferenceControllerTest {
                 new MagnificationGesturesPreferenceController(mContext, "bad_key");
         assertThat(controller.isSliceable()).isFalse();
     }
+
+    @Test
+    public void isPublicSlice_returnTrue() {
+        assertThat(mController.isPublicSlice()).isTrue();
+    }
 }
index 08b53b2..83fe496 100644 (file)
@@ -174,4 +174,9 @@ public class MagnificationNavbarPreferenceControllerTest {
                 new MagnificationNavbarPreferenceController(mContext, "bad_key");
         assertThat(controller.isSliceable()).isFalse();
     }
+
+    @Test
+    public void isPublicSlice_returnTrue() {
+        assertThat(mController.isPublicSlice()).isTrue();
+    }
 }