OSDN Git Service

staging: fsl-mc/dpio: Propagate error code
authorIoana Radulescu <ruxandra.radulescu@nxp.com>
Thu, 15 Jun 2017 08:55:06 +0000 (03:55 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jun 2017 16:41:33 +0000 (18:41 +0200)
dpaa2_io_service_register() returns zero even if
qbman_swp_CDAN_set() encountered an error. Fix this
by propagating the error code so the caller is informed
data availability notifications are not properly set
for a channel.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Acked-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/dpio/dpio-service.c

index 8c45f81..f809682 100644 (file)
@@ -260,9 +260,9 @@ int dpaa2_io_service_register(struct dpaa2_io *d,
 
        /* Enable the generation of CDAN notifications */
        if (ctx->is_cdan)
-               qbman_swp_CDAN_set_context_enable(d->swp,
-                                                 (u16)ctx->id,
-                                                 ctx->qman64);
+               return qbman_swp_CDAN_set_context_enable(d->swp,
+                                                        (u16)ctx->id,
+                                                        ctx->qman64);
        return 0;
 }
 EXPORT_SYMBOL(dpaa2_io_service_register);