OSDN Git Service

staging: rtl8188eu: refactor cckrates_included()
authorMichael Straube <straube.linux@gmail.com>
Wed, 5 Dec 2018 18:30:49 +0000 (19:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 15:12:18 +0000 (16:12 +0100)
Refactor cckrates_included() to improve readability and slightly
reduce object file size. Also change the return type to bool.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_wlan_util.c
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h

index 2491822..90160d5 100644 (file)
@@ -56,13 +56,14 @@ static u8 rtw_basic_rate_mix[7] = {
        IEEE80211_OFDM_RATE_24MB | IEEE80211_BASIC_RATE_MASK
 };
 
-int cckrates_included(unsigned char *rate, int ratelen)
+bool cckrates_included(unsigned char *rate, int ratelen)
 {
-       int     i;
+       int i;
 
        for (i = 0; i < ratelen; i++) {
-               if  ((((rate[i]) & 0x7f) == 2)  || (((rate[i]) & 0x7f) == 4) ||
-                    (((rate[i]) & 0x7f) == 11)  || (((rate[i]) & 0x7f) == 22))
+               u8 r = rate[i] & 0x7f;
+
+               if (r == 2 || r == 4 || r == 11 || r == 22)
                        return true;
        }
        return false;
index 9526da3..c86dec1 100644 (file)
@@ -580,7 +580,7 @@ void addba_timer_hdl(struct timer_list *t);
        mod_timer(&mlmeext->link_timer, jiffies +       \
                  msecs_to_jiffies(ms))
 
-int cckrates_included(unsigned char *rate, int ratelen);
+bool cckrates_included(unsigned char *rate, int ratelen);
 int cckratesonly_included(unsigned char *rate, int ratelen);
 
 void process_addba_req(struct adapter *padapter, u8 *paddba_req, u8 *addr);