OSDN Git Service

nfc: st21nfca: remove redundant assignment to variable i
authorColin Ian King <colin.i.king@gmail.com>
Thu, 30 Dec 2021 16:12:30 +0000 (16:12 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 31 Dec 2021 01:26:58 +0000 (17:26 -0800)
Variable i is being assigned a value that is never read, the
assignment is redundant and can be removed. Cleans up clang-scan
build warning:

drivers/nfc/st21nfca/i2c.c:319:4: warning: Value stored to 'i'
is never read [deadcode.DeadStores]
                        i = 0;

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20211230161230.428457-1-colin.i.king@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/st21nfca/i2c.c

index 35b32fb..a86b5ed 100644 (file)
@@ -315,10 +315,8 @@ static int st21nfca_hci_i2c_repack(struct sk_buff *skb)
                skb_pull(skb, 1);
 
                r = check_crc(skb->data, skb->len);
-               if (r != 0) {
-                       i = 0;
+               if (r != 0)
                        return -EBADMSG;
-               }
 
                /* remove headbyte */
                skb_pull(skb, 1);