OSDN Git Service

staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx
authorTim Collier <osdevtc@gmail.com>
Wed, 25 Jul 2018 19:30:31 +0000 (20:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Jul 2018 08:08:02 +0000 (10:08 +0200)
Fix checkpatch.pl warning:

"Use of volatile is usually wrong: see
Documentation/process/volatile-considered-harmful.rs"

reapable is not used to access h/w directly, so volatile is not
necessary.

>From reading the code, the contexts in which the field may be
updated/accessed across threads are protected by the hw->ctlxq.lock
spinlock, where hw is the device struct, so appears thread-safe.

Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/hfa384x.h

index 67a944c..992ebaa 100644 (file)
@@ -1176,7 +1176,7 @@ struct hfa384x_usbctlx {
        enum ctlx_state state;  /* Tracks running state */
 
        struct completion done;
-       volatile int reapable;  /* Food for the reaper task */
+       int reapable;           /* Food for the reaper task */
 
        ctlx_cmdcb_t cmdcb;     /* Async command callback */
        ctlx_usercb_t usercb;   /* Async user callback, */