t4209: use helper functions to test --author

Also add tests for case sensitive and non-matching cases.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh
index eaa14a0..138118a 100755 (executable)
--- a/t/t4209-log-pickaxe.sh
+++ b/t/t4209-log-pickaxe.sh
@@ -60,15 +60,10 @@ test_log    expect_nomatch  --grep InItial
 test_log_icase expect_initial  --grep InItial
 test_log_icase expect_nomatch  --grep initail
 
-test_expect_success 'log --author --regexp-ignore-case' '
-       git log --regexp-ignore-case --author=person --format=%H >actual &&
-       test_cmp expect_second actual
-'
-
-test_expect_success 'log --author -i' '
-       git log -i --author=person --format=%H >actual &&
-       test_cmp expect_second actual
-'
+test_log       expect_second   --author Person
+test_log       expect_nomatch  --author person
+test_log_icase expect_second   --author person
+test_log_icase expect_nomatch  --author spreon
 
 test_log       expect_nomatch  -G picked
 test_log       expect_second   -G Picked