OSDN Git Service

media: TDA1997x: Fix the error handling in tda1997x_probe()
authorZheyu Ma <zheyuma97@gmail.com>
Tue, 10 May 2022 13:41:46 +0000 (14:41 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Jun 2022 09:30:30 +0000 (10:30 +0100)
The driver should disable the regulator when failing to probe.

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Acked-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/tda1997x.c

index 8fafce2..0de7acd 100644 (file)
@@ -2798,6 +2798,7 @@ err_free_mutex:
        cancel_delayed_work(&state->delayed_work_enable_hpd);
        mutex_destroy(&state->page_lock);
        mutex_destroy(&state->lock);
+       tda1997x_set_power(state, 0);
 err_free_state:
        kfree(state);
        dev_err(&client->dev, "%s failed: %d\n", __func__, ret);