OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
baa829d
)
[NETFILTER]: arp_tables: fix NULL pointer dereference
author
Patrick McHardy
<kaber@trash.net>
Mon, 13 Mar 2006 04:40:43 +0000
(20:40 -0800)
committer
David S. Miller
<davem@davemloft.net>
Mon, 13 Mar 2006 04:40:43 +0000
(20:40 -0800)
The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL)
is true.
Coverity #190
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/arp_tables.c
patch
|
blob
|
history
diff --git
a/net/ipv4/netfilter/arp_tables.c
b/net/ipv4/netfilter/arp_tables.c
index
dd1048b
..
7d7ab94
100644
(file)
--- a/
net/ipv4/netfilter/arp_tables.c
+++ b/
net/ipv4/netfilter/arp_tables.c
@@
-771,7
+771,7
@@
static int get_entries(const struct arpt_get_entries *entries,
struct arpt_table *t;
t = xt_find_table_lock(NF_ARP, entries->name);
- if (t
||
!IS_ERR(t)) {
+ if (t
&&
!IS_ERR(t)) {
struct xt_table_info *private = t->private;
duprintf("t->private->number = %u\n",
private->number);