OSDN Git Service

RDMA/bnxt: Delete 'nq_ptr' variable which is not used
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 19 Apr 2020 13:20:46 +0000 (16:20 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 22 Apr 2020 20:05:13 +0000 (17:05 -0300)
The variable "nq_ptr" is set but never used, this generates the following
warning while compiling kernel with W=1 option.

drivers/infiniband/hw/bnxt_re/qplib_fp.c: In function 'bnxt_qplib_service_nq':
drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:25: warning:
   variable 'nq_ptr' set but not used [-Wunused-but-set-variable]
303 |  struct nq_base *nqe, **nq_ptr;
    |

Fixes: fddcbbb02af4 ("RDMA/bnxt_re: Simplify obtaining queue entry from hw ring")
Link: https://lore.kernel.org/r/20200419132046.123887-1-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/bnxt_re/qplib_fp.c

index a4de56b..c5e2957 100644 (file)
@@ -300,12 +300,12 @@ static void bnxt_qplib_service_nq(unsigned long data)
 {
        struct bnxt_qplib_nq *nq = (struct bnxt_qplib_nq *)data;
        struct bnxt_qplib_hwq *hwq = &nq->hwq;
-       struct nq_base *nqe, **nq_ptr;
        int num_srqne_processed = 0;
        int num_cqne_processed = 0;
        struct bnxt_qplib_cq *cq;
        int budget = nq->budget;
        u32 sw_cons, raw_cons;
+       struct nq_base *nqe;
        uintptr_t q_handle;
        u16 type;
 
@@ -314,7 +314,6 @@ static void bnxt_qplib_service_nq(unsigned long data)
        raw_cons = hwq->cons;
        while (budget--) {
                sw_cons = HWQ_CMP(raw_cons, hwq);
-               nq_ptr = (struct nq_base **)hwq->pbl_ptr;
                nqe = bnxt_qplib_get_qe(hwq, sw_cons, NULL);
                if (!NQE_CMP_VALID(nqe, raw_cons, hwq->max_elements))
                        break;