OSDN Git Service

mm/hugetlb: remove unnecessary 'NULL' values from pointer
authorXU pengfei <xupengfei@nfschina.com>
Wed, 14 Sep 2022 01:21:14 +0000 (09:21 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 3 Oct 2022 21:03:15 +0000 (14:03 -0700)
Pointer variables allocate memory first, and then judge.  There is no need
to initialize the assignment.

Link: https://lkml.kernel.org/r/20220914012113.6271-1-xupengfei@nfschina.com
Signed-off-by: XU pengfei <xupengfei@nfschina.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb.c

index 0b1ab5a..d4347ae 100644 (file)
@@ -258,7 +258,7 @@ static inline struct hugepage_subpool *subpool_vma(struct vm_area_struct *vma)
 static struct file_region *
 get_file_region_entry_from_cache(struct resv_map *resv, long from, long to)
 {
-       struct file_region *nrg = NULL;
+       struct file_region *nrg;
 
        VM_BUG_ON(resv->region_cache_count <= 0);
 
@@ -340,7 +340,7 @@ static bool has_same_uncharge_info(struct file_region *rg,
 
 static void coalesce_file_region(struct resv_map *resv, struct file_region *rg)
 {
-       struct file_region *nrg = NULL, *prg = NULL;
+       struct file_region *nrg, *prg;
 
        prg = list_prev_entry(rg, link);
        if (&prg->link != &resv->regions && prg->to == rg->from &&