fix krazy warnings

diff --git a/doc/examples/addressbook-sdk/part7/addressbook.cpp b/doc/examples/addressbook-sdk/part7/addressbook.cpp
index 25aaf8c..e4eedbe 100644 (file)
--- a/doc/examples/addressbook-sdk/part7/addressbook.cpp
+++ b/doc/examples/addressbook-sdk/part7/addressbook.cpp
@@ -352,7 +352,7 @@ void AddressBook::exportAsVCard()
         lastName = nameList.last();
     } else {
         firstName = name;
-        lastName = "";
+        lastName.clear();
     }
 
     QString fileName = QFileDialog::getSaveFileName(this,
@@ -381,9 +381,9 @@ void AddressBook::exportAsVCard()
     else
         out << "FN:" << firstName << "\n";
 
-    address.replace(";", "\\;", Qt::CaseInsensitive);
-    address.replace("\n", ";", Qt::CaseInsensitive);
-    address.replace(",", " ", Qt::CaseInsensitive);
+    address.replace(';', "\\;", Qt::CaseInsensitive);
+    address.replace('\n', ";", Qt::CaseInsensitive);
+    address.replace(',', " ", Qt::CaseInsensitive);
 
     out << "ADR;HOME:;" << address << "\n";
     out << "END;VCARD" << "\n";

diff --git a/src/plugins/bazaar/pullorpushdialog.h b/src/plugins/bazaar/pullorpushdialog.h
index e3f403e..6424b03 100644 (file)
--- a/src/plugins/bazaar/pullorpushdialog.h
+++ b/src/plugins/bazaar/pullorpushdialog.h
@@ -51,7 +51,7 @@ public:
         PushMode
     };
 
-    PullOrPushDialog(Mode mode, QWidget *parent = 0);
+    explicit PullOrPushDialog(Mode mode, QWidget *parent = 0);
     ~PullOrPushDialog();
 
     // Common parameters and options

diff --git a/src/plugins/debugger/name_demangler.cpp b/src/plugins/debugger/name_demangler.cpp
index 8a862b4..5b96441 100644 (file)
--- a/src/plugins/debugger/name_demangler.cpp
+++ b/src/plugins/debugger/name_demangler.cpp
@@ -332,7 +332,7 @@ bool NameDemanglerPrivate::demangle(const QString &mangledName)
 
 #ifdef DO_TRACE
     qDebug("%d", substitutions.size());
-    foreach (QString s, substitutions)
+    foreach (const QString &s, substitutions)
         qDebug(qPrintable(s));
 #endif
     return !parseError;