OSDN Git Service

NFC: st21nfca: Remove useless err == 0 condition
authorChristophe Ricard <christophe.ricard@gmail.com>
Sun, 10 Aug 2014 22:04:53 +0000 (00:04 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 7 Sep 2014 22:04:22 +0000 (00:04 +0200)
On top of st21nfca_im_recv_atr_res_cb and st21nfca_im_recv_dep_res_cb a
condition if (err != 0) is present. Because err is never modified in the
code err will always be 0 at the end.

The condition can be removed.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st21nfca/st21nfca_dep.c

index cd942c5..979c969 100644 (file)
@@ -485,8 +485,7 @@ static void st21nfca_im_recv_atr_res_cb(void *context, struct sk_buff *skb,
                                                ST21NFCA_PP2LRI(atr_res->ppi));
                break;
        default:
-               if (err == 0)
-                       kfree_skb(skb);
+               kfree_skb(skb);
                break;
        }
 }
@@ -616,8 +615,7 @@ static void st21nfca_im_recv_dep_res_cb(void *context, struct sk_buff *skb,
        }
 
 exit:
-       if (err == 0)
-               kfree_skb(skb);
+       kfree_skb(skb);
 }
 
 int st21nfca_im_send_dep_req(struct nfc_hci_dev *hdev, struct sk_buff *skb)