OSDN Git Service

Fix possible crash in qmakestepwidget
authorTobias Hunger <tobias.hunger@nokia.com>
Mon, 16 May 2011 10:37:50 +0000 (12:37 +0200)
committerTobias Hunger <tobias.hunger@nokia.com>
Mon, 16 May 2011 16:26:18 +0000 (18:26 +0200)
Reviewed-by: dt
src/plugins/qt4projectmanager/qmakestep.cpp

index b2c349a..063ea83 100644 (file)
@@ -498,10 +498,9 @@ void QMakeStepConfigWidget::qtVersionChanged()
 
 void QMakeStepConfigWidget::qtVersionsDumpUpdated(const QString &qmakeCommand)
 {
-    if (BaseQtVersion *version = m_step->qt4BuildConfiguration()->qtVersion()) {
-        if (version->qmakeCommand() == qmakeCommand)
-            qtVersionChanged();
-    }
+    BaseQtVersion *version = m_step->qt4BuildConfiguration()->qtVersion();
+    if (version && version->qmakeCommand() == qmakeCommand)
+        qtVersionChanged();
 }
 
 void QMakeStepConfigWidget::qmakeBuildConfigChanged()