OSDN Git Service

drm/bridge: tc358767: Replace magic number in tc_main_link_enable()
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Wed, 19 Jun 2019 05:27:15 +0000 (22:27 -0700)
committerAndrzej Hajda <a.hajda@samsung.com>
Thu, 27 Jun 2019 11:38:21 +0000 (13:38 +0200)
We don't need 8 byte array, DP_LINK_STATUS_SIZE (6) should be
enough. This also gets rid of a magic number as a bonus.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-15-andrew.smirnov@gmail.com
drivers/gpu/drm/bridge/tc358767.c

index af14c7c..38f15e7 100644 (file)
@@ -849,7 +849,7 @@ static int tc_main_link_enable(struct tc_data *tc)
        u32 dp_phy_ctrl;
        u32 value;
        int ret;
-       u8 tmp[8];
+       u8 tmp[DP_LINK_STATUS_SIZE];
 
        dev_dbg(tc->dev, "link enable\n");