OSDN Git Service

s390/qeth: don't keep statistics for tx timeout
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 17 Apr 2019 16:17:31 +0000 (18:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Apr 2019 17:33:59 +0000 (10:33 -0700)
struct netdev_queue contains a counter for tx timeouts, which gets
updated by dev_watchdog(). So let's not attempt to maintain our own
statistics, in particular not by overloading the skb-error counter.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_core_main.c

index 41e3bc4..7309301 100644 (file)
@@ -464,7 +464,6 @@ struct qeth_card_stats {
        u64 rx_errors;
        u64 rx_dropped;
        u64 rx_multicast;
-       u64 tx_errors;
 };
 
 struct qeth_out_q_stats {
index 9e495df..09ed9e0 100644 (file)
@@ -4340,7 +4340,6 @@ void qeth_tx_timeout(struct net_device *dev)
 
        card = dev->ml_priv;
        QETH_CARD_TEXT(card, 4, "txtimeo");
-       QETH_CARD_STAT_INC(card, tx_errors);
        qeth_schedule_recovery(card);
 }
 EXPORT_SYMBOL_GPL(qeth_tx_timeout);
@@ -6192,7 +6191,6 @@ void qeth_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
        stats->rx_errors = card->stats.rx_errors;
        stats->rx_dropped = card->stats.rx_dropped;
        stats->multicast = card->stats.rx_multicast;
-       stats->tx_errors = card->stats.tx_errors;
 
        for (i = 0; i < card->qdio.no_out_queues; i++) {
                queue = card->qdio.out_qs[i];