OSDN Git Service

media: ipu3-cio2: Fix mbus_code processing in cio2_subdev_set_fmt()
authorPavel Machek <pavel@denx.de>
Wed, 30 Dec 2020 12:55:50 +0000 (13:55 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 16:09:57 +0000 (17:09 +0100)
Loop was useless as it would always exit on the first iteration. Fix
it with right condition.

Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Fixes: a86cf9b29e8b ("media: ipu3-cio2: Validate mbus format in setting subdev format")
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@vger.kernel.org # v4.16 and up
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/intel/ipu3/ipu3-cio2.c

index 36e354e..e8ea69d 100644 (file)
@@ -1269,7 +1269,7 @@ static int cio2_subdev_set_fmt(struct v4l2_subdev *sd,
        fmt->format.code = formats[0].mbus_code;
 
        for (i = 0; i < ARRAY_SIZE(formats); i++) {
-               if (formats[i].mbus_code == fmt->format.code) {
+               if (formats[i].mbus_code == mbus_code) {
                        fmt->format.code = mbus_code;
                        break;
                }