OSDN Git Service

Input: adxl34x - clean up a data type in adxl34x_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 27 Oct 2020 00:10:09 +0000 (17:10 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 27 Oct 2020 03:56:27 +0000 (20:56 -0700)
The "revid" is used to store negative error codes so it should be an int
type.

Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20201026072824.GA1620546@mwanda
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/adxl34x.c

index 5fe92d4..4cc4e8f 100644 (file)
@@ -696,7 +696,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
        struct input_dev *input_dev;
        const struct adxl34x_platform_data *pdata;
        int err, range, i;
-       unsigned char revid;
+       int revid;
 
        if (!irq) {
                dev_err(dev, "no IRQ?\n");