OSDN Git Service

mac80211: fix sta_info_flush() return value
authorJohannes Berg <johannes.berg@intel.com>
Sat, 25 Feb 2012 20:40:46 +0000 (21:40 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 27 Feb 2012 19:06:42 +0000 (14:06 -0500)
The comment for sta_info_flush() states
"Returns the number of removed STA entries"
but that isn't actually true. Consequently,
the warning when a station is still around
on interface removal can never trigger and
this delayed finding the timer issue the
previous patch fixed. Fix the return value
here to make that warning useful again.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/sta_info.c

index 4034ee6..98613c8 100644 (file)
@@ -865,8 +865,10 @@ int sta_info_flush(struct ieee80211_local *local,
 
        mutex_lock(&local->sta_mtx);
        list_for_each_entry_safe(sta, tmp, &local->sta_list, list) {
-               if (!sdata || sdata == sta->sdata)
+               if (!sdata || sdata == sta->sdata) {
                        WARN_ON(__sta_info_destroy(sta));
+                       ret++;
+               }
        }
        mutex_unlock(&local->sta_mtx);