OSDN Git Service

RDMA/device: Use __ib_device_get_by_name() in ib_device_rename()
authorJason Gunthorpe <jgg@mellanox.com>
Sat, 12 Jan 2019 02:42:42 +0000 (02:42 +0000)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 18 Jan 2019 20:05:58 +0000 (13:05 -0700)
No reason to open code this loop.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
drivers/infiniband/core/device.c

index f8180cf..4a9aa6d 100644 (file)
@@ -183,18 +183,15 @@ static struct ib_device *__ib_device_get_by_name(const char *name)
 
 int ib_device_rename(struct ib_device *ibdev, const char *name)
 {
-       struct ib_device *device;
        int ret = 0;
 
        if (!strcmp(name, dev_name(&ibdev->dev)))
                return ret;
 
        mutex_lock(&device_mutex);
-       list_for_each_entry(device, &device_list, core_list) {
-               if (!strcmp(name, dev_name(&device->dev))) {
-                       ret = -EEXIST;
-                       goto out;
-               }
+       if (__ib_device_get_by_name(name)) {
+               ret = -EEXIST;
+               goto out;
        }
 
        ret = device_rename(&ibdev->dev, name);